ui: Ensure we clean up javascript based DataSources #10915
Conversation
|
|
johncowen
force-pushed
the
ui/bugfix/clean-up-routing-config
branch
from
88624a2
to
234ea57
Compare
|
This is now just for 1.10.x and is therefore currently waiting on #11127 |
DataSources added via javascript require cleaning up by assigning it to an EventSource component in the template, otherwise the blocking query can stick around when its no longer needed. We also took the opportunity here to make this consistent with the rest of the application. 1. Don't use `@model`. 2. Use our <Route /> component. 3. Use extra divs/spans specifically for styling only as a last resort.
johncowen
force-pushed
the
ui/bugfix/clean-up-routing-config
branch
from
234ea57
to
fb296aa
Compare
|
Ok so #11095 and #11127 are now in a rebased here and the tests are now passing as expected. We don't need this fix on Problem now is, I added a changelog to explain the change here, but the GH action (changelog-checker) is telling me I haven't 😭 Kinda wondering whether I should just bypass that and merge, will ask the team |
|
Changelog is added here, we need to tweak the changelog-checker script slightly, which we'll do post merge. |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/457052. |
Continuation of #10835
DataSources added via javascript require cleaning up by assigning it to
an EventSource component in the template, otherwise the blocking query
can stick around when its no longer needed.
We also took the opportunity here to make this consistent with the rest
of the application.
@model.<Route />component.